Make app title configurable #1264
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fuenfundachtzig
force-pushed
the
feature/configure-title
branch
from
c3070de
to
00c3eb7
Compare
| @@ -81,6 +83,28 @@ export const AppConfigForm: React.FC = () => { | |||
| </FormItem> | |||
| )} | |||
| /> | |||
| <FormField | |||
| control={form.control} | |||
| name="apptitle" | |||
There was a problem hiding this comment.
can we change the field to just title?
There was a problem hiding this comment.
I found just "title" a bit ambiguous? But I am happy to change this if you prefer title. (Any alternative suggestions also welcome, of course.)
There was a problem hiding this comment.
sorry for the late response - maybe app_title then, instead of without a space
There was a problem hiding this comment.
after that, i think everything looks good! thanks for the awesome contribution
There was a problem hiding this comment.
sorry for the late response - maybe
app_titlethen, instead of without a space
Sounds good, I will change to that.
There was a problem hiding this comment.
after that, i think everything looks good! thanks for the awesome contribution
Thanks :)
marimo/_ast/app.py
Outdated
| @@ -55,6 +55,7 @@ class _AppConfig: | |||
| """ | |||
|
|
|||
| width: Literal["normal", "medium", "full"] = "normal" | |||
| apptitle: Optional[str] = None | |||
There was a problem hiding this comment.
could we add some tests to test_codegen to validate parsing from py and writing to py
There was a problem hiding this comment.
it would be codegen.generate_filecontents and codegen.get_app
There was a problem hiding this comment.
I have added some tests. (Doing so I found there is already quite a large number of tests 😁)
fuenfundachtzig
force-pushed
the
feature/configure-title
branch
from
e37f7e4
to
bf71b22
Compare
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.4.8-dev5 |
This PR adds a field in the configuration that allows the user to change the title (HTML <title>) displayed in the browser.