Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unmount react component when web-component unmounts #163

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

mscolnick
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 2:30pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 2:30pm

@mscolnick mscolnick changed the title Unmount react component when web-component unmounts fix: unmount react component when web-component unmounts Sep 28, 2023
akshayka
akshayka previously approved these changes Sep 28, 2023
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo failing lint

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants