improvement: auto-encoding pandas/numpy, mo.ui.table takes in Dataframe #197
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marimo/_plugins/ui/_impl/table.py
Outdated
|
|
||
| def __init__( | ||
| self, | ||
| data: TableData, |
There was a problem hiding this comment.
I know it's kind of ugly, but can you inline this type? That makes the docs / autocomplete more useful to the user.
There was a problem hiding this comment.
I think that might also make the type error in the docs CI go away. Otherwise you can replace the | with Union
There was a problem hiding this comment.
switched to union, and inline here (where its used in the docs), but kept everywhere else DRYed up
|
|
||
| class WebComponentEncoder(JSONEncoder): | ||
| """Custom JSON encoder for WebComponents""" | ||
|
|
||
| def default(self, obj: Any) -> Any: | ||
| # Handle numpy objects |
marimo/_plugins/ui/_impl/table.py
Outdated
|
|
||
| **Initialization Args.** | ||
|
|
||
| - `data`: a list of values representing a column, or a list of dicts |
There was a problem hiding this comment.
update doc to mention that data can be a dataframe? I'd start with that.
"A pandas dataframe, or a list of values representing a column, or a list of dicts ...
marimo/_plugins/ui/_impl/table.py
Outdated
| ```python | ||
| # df is a Pandas dataframe | ||
| table = mo.ui.table( | ||
| data=df.to_dict('records'), |
marimo/_plugins/ui/_impl/table.py
Outdated
| list[dict[str, str]], | ||
| Sequence[str | int | float | bool | MIME | None], |
There was a problem hiding this comment.
Why do we need list[dict[str, str]]?
There was a problem hiding this comment.
technically our values in the dicts need to be homegenious. this makes the typings super ugly, so i removed this and just type ignored the response from to_dicts
mscolnick
force-pushed
the
ms/table-pandas
branch
from
d7dcfa0
to
6da8c03
Compare
No description provided.