parse docstrings as markdown in autocomplete #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akshayka
commented
Oct 11, 2023
akshayka
commented
- greatly improves readability of marimo docstrings in autocomplete
- doesn't seem to hurt readability of other docstrings, though there may be edge cases
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Oct 11, 2023
frontend/src/editor/Cell.tsx
Outdated
| @@ -359,7 +359,7 @@ const CellComponent = ( | |||
| !cellRef.current.contains(e.relatedTarget) && | |||
| editorView.current !== null | |||
| ) { | |||
| closeCompletion(editorView.current); | |||
| //closeCompletion(editorView.current); | |||
mscolnick
previously approved these changes
Oct 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.