Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Custom altair data_transformer, load 1 million points #200

Merged
merged 8 commits into from
Oct 12, 2023
Merged

improvement: Custom altair data_transformer, load 1 million points #200

merged 8 commits into from
Oct 12, 2023

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Oct 12, 2023 •
edited
Loading

  • add custom altair data_transformer for csv and json (default to csv)
  • add smoke_test for 1 million flights
  • fix shared memory buffer to use the write buffer offset

@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 5:06am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 5:06am

@mscolnick mscolnick changed the title ms/virtual file in charts improvement: Custom altair data_transformer, load 1 million points Oct 12, 2023
akshayka
akshayka approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I pushed a change to rename the figure arg to altair_chart back to chart. My bad. I had changed it earlier in the previous PR, when I was experimenting with renaming to plot. Forgot to change it back.

@akshayka akshayka merged commit 3293c13 into main Oct 12, 2023
19 checks passed
@akshayka akshayka deleted the ms/virtual-file-in-charts branch October 12, 2023 05:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akshayka akshayka akshayka approved these changes

Assignees
No one assigned
Labels
merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mscolnick @akshayka