-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reactive execution on ui.array
and ui.dictionary
's contained elements
#690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
previously approved these changes
Jan 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to extract elements contained in
mo.ui.array
andmo.ui.dictionary
objects, embed them in other outputs, and have reactivity flow through the original container elements.This means that it is now possible to create outputs with a dynamic number of elements (eg, a
table
with a column ofui.button
objects) at runtime, and have reactivity +on_change
handlers work, without usingui.batch
.A simple example:
The smoke test has more interesting examples.
This change also adds methods to
array
,dictionary
to make them emulate Python'slist
anddict
containers.In the implementation, we make it possible to register a UI element as a view of another UI element;
ui.array
andbatch_base
are updated to make use of this method. A new function is added to the registry that recursively resolves a value update on a view of a UI element to a value update on the source/parent element. The runtime uses this method to resolveSetUIElementValueRequest
s on views to their parents.