Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvment: consistent error toasting on all request #969

Merged
merged 1 commit into from
Mar 21, 2024
Merged

improvment: consistent error toasting on all request #969

merged 1 commit into from
Mar 21, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Mar 20, 2024 •
edited
Loading

  • Consolidate error toasting to a single file
  • remove old error toasting spread throughout
  • remove Open File in pyodide

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 8:58pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 8:58pm

@mscolnick mscolnick requested a review from akshayka March 20, 2024 23:32
akshayka
akshayka approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@akshayka akshayka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Not sure why the CLI test is failing.

@mscolnick mscolnick merged commit 5259a07 into main Mar 21, 2024
25 of 29 checks passed
@mscolnick mscolnick deleted the ms/better-toasting branch March 21, 2024 01:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akshayka akshayka akshayka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mscolnick @akshayka