Run Web Platform Tests against the polyfill. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See step 4 in "The get(options) method" section in the [CookieStore Spec][cookiestore]: >If options is empty, then return a promise rejected with a TypeError. [cookiestore]: https://wicg.github.io/cookie-store/#ref-for-dom-cookiestore-get-options%E2%91%A4
keithamus
approved these changes
Nov 30, 2020
markcellus
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Throw TypeError if get is called without arguments See step 4 in "The get(options) method" section in the [CookieStore Spec][cookiestore]: >If options is empty, then return a promise rejected with a TypeError. [cookiestore]: https://wicg.github.io/cookie-store/#ref-for-dom-cookiestore-get-options%E2%91%A4 * Refactor sanitizeOptions to use TypeScript generics * Implement getting a cookie by URL * Add cookieStore get arguments WPT tests * Set `assert_equals` variable directly * Actually parse URL and check its origin
markcellus
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Throw TypeError if get is called without arguments See step 4 in "The get(options) method" section in the [CookieStore Spec][cookiestore]: >If options is empty, then return a promise rejected with a TypeError. [cookiestore]: https://wicg.github.io/cookie-store/#ref-for-dom-cookiestore-get-options%E2%91%A4 * Refactor sanitizeOptions to use TypeScript generics * Implement getting a cookie by URL * Add cookieStore get arguments WPT tests * Set `assert_equals` variable directly * Actually parse URL and check its origin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a test harness set up so that we are able to run Web Platform Tests against the polyfill. These tests are a good indicator of if the polyfill is fulfilling the spec since browser vendors use these tests to make sure that their implementations are matching the spec and each others implementation.
This change just pulls in a single test suite but I'll be building up a framework so that we can pull in all the cookie store tests and vendor them into the repo. The single test suite that this PR pulls in is
wpt/cookie-store/cookieStore_get_arguments.tentative.https.any.html.I had to make some modifications since the tests didn't run green from the beginning but I believe my changes align us closer to the spec.
cc/ @keithamus