Skip to content

Adds selection range provider #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

Adds selection range provider #3

merged 1 commit into from
Jun 13, 2023

Conversation

rpaul-stripe
Copy link
Collaborator

  • Adds a selection range provider that matches against Markdoc tags and tag interiors in order to support the "expand selection" command with behavior similar to what VSCode already provides for HTML tags
  • Adds test cases for the selection range provider that verify the correctness of the implementation
  • Modifies the validation provider so that it shows the validation error ID as the error code in the "problems" panel table view

@rpaul-stripe rpaul-stripe requested a review from mfix-stripe June 13, 2023 15:22
@rpaul-stripe rpaul-stripe merged commit 4932167 into main Jun 13, 2023
@rpaul-stripe rpaul-stripe deleted the rpaul-selection-range-provider branch June 13, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfix-stripe mfix-stripe mfix-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpaul-stripe @mfix-stripe