Fix null scalar formatting #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mfix-stripe
reviewed
Feb 1, 2023
| @@ -21,7 +21,7 @@ Markdoc is a **Markdown**-based \`syntax\` and _toolchain_ for creating ~~custom | |||
| [Link](/href "title") | |||
|  | |||
|
|
|||
| {% callout #id .class .class2 a="check" b={"e":{"with space": 5}} c=8 d=[1, "2",true] %} | |||
| {% callout #id .class .class2 a="check" b={"e":{"with space": 5}} c=8 d=[1, "2",true, null] %} | |||
There was a problem hiding this comment.
PTAL @rpaul-stripe — I didn't think we supported "null" in the syntax.
There was a problem hiding this comment.
We actually do support null as a valid scalar in Markdoc tags: https://github.com/markdoc/markdoc/blob/main/src/grammar/tag.pegjs#L119-L120
There was a problem hiding this comment.
Ooh! Missed that in the grammar. Let's merge this then huh @rpaul-stripe ?
There was a problem hiding this comment.
@mfix-stripe yeah, I think this looks right to me. 👍
rpaul-stripe
approved these changes
Feb 1, 2023
|
Thanks @emmatown! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.