Fix some timing issues with SSL tests. #1740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
previously approved these changes
Mar 31, 2025
| DatabaseClient sslClient = Common.newClientBuilder() | ||
| .withUsername(Common.SERVER_ADMIN_USER) | ||
| .withPassword(Common.SERVER_ADMIN_PASS) | ||
| .withSSLContext(sslContext) |
There was a problem hiding this comment.
Try it with just .withSSLProtocol("TLSv1.2"), you shouldn't need to build an SSLContext yourself, the builder wll do it for you and will use the "trust all" trust manager.
Change the Docker stack name to help Sameera.
BillFarber
force-pushed
the
task/sslImprovements
branch
from
6a9a345 to
a35f769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Docker stack name to help Sameera.