feat: add support for jest 26, log warnings with legacy configs #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanPiercey
force-pushed
the
jest-26-support
branch
from
e30a9fc to
46ef443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jest broke us jestjs/jest#10036. Specifically our reliance on the
browseroption jest used which allowed us to have a common preset which could target both server and browser compilations and module resolution.The only way for us to support
jest@26and above is to split these into two presets and transformers.The new top level api is:
for jsdom support and
for testing server side components in the node environment.
Like wise the
transformhas been split into two and can be accessed via@marko/jest/transform/nodeand@marko/jest/transform/browser.The default preset has been left in this release but now logs a warning if you are below jest 25 and throws is you are on jest 26.
Motivation and Context
Screenshots (if appropriate):
Checklist: