Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md # id links don't work on github.com #50

Closed
JoshuaKGoldberg opened this issue Aug 10, 2023 · 2 comments
Closed

README.md # id links don't work on github.com #50

JoshuaKGoldberg opened this issue Aug 10, 2023 · 2 comments
Assignees
@markteekman
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@JoshuaKGoldberg
Copy link
Contributor

Looking at the Skip to: links in the README.md:

  • Actual link: https://github.com/markteekman/accessible-astro-components#Accordion
  • Expected link: https://github.com/markteekman/accessible-astro-components#accordion

Note the casing difference.
@markteekman
Copy link
Owner

Hey @JoshuaKGoldberg, oh I didn't know! It always worked on the NPM page, it seems to be more forgiving of capitals then GitHub 🙂 Thanks for noticing!

@markteekman markteekman self-assigned this Aug 11, 2023
@markteekman markteekman added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers labels Aug 11, 2023
markteekman added a commit that referenced this issue Aug 11, 2023
@markteekman
Update README.md #50
edb6f19
@JoshuaKGoldberg
Copy link
Contributor Author

Fixed by edb6f19 :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markteekman markteekman

Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @markteekman