Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Add File field #256

Merged
merged 9 commits into from
Feb 2, 2015
Merged

[RFR] Add File field #256

merged 9 commits into from
Feb 2, 2015

Conversation

jeromemacias
Copy link
Contributor

Refs #52, supersede #96.

To do:

  • Add file field
  • Manage multiple file upload

File field, single file upload:
image

Multiple files upload:
image

@fzaninotto
Copy link
Member

So just to be sure, this is a single file upload widget, not a multiple file upload, right?

@jeromemacias
Copy link
Contributor Author

There is an option to handle multiple file uploads, so I need to display all uploaded files (only the first one is displayed at the moment).

@jeromemacias jeromemacias force-pushed the file_field branch 2 times, most recently from 00b3da6 to 337425b Compare January 29, 2015 15:16
@jeromemacias jeromemacias changed the title [WIP] Add File field [RFR] Add File field Feb 1, 2015
fzaninotto
fzaninotto reviewed Feb 2, 2015
View reviewed changes
src/javascripts/ng-admin/Crud/field/maFileField.js
restrict: 'E',
link: {
pre: function(scope) {
var uploadInformation = scope.field().config.uploadInformation;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not access the config like that, it's an internal property. Use scope.field().uploadInformation() instead.

@fzaninotto
Copy link
Member

Please add a mention in the README, too.

fzaninotto added a commit that referenced this pull request Feb 2, 2015
@fzaninotto
Merge pull request #256 from marmelab/file_field
2375544 
[RFR] Add File field
@fzaninotto fzaninotto merged commit 2375544 into master Feb 2, 2015
@fzaninotto fzaninotto deleted the file_field branch February 2, 2015 16:08
This was referenced Feb 3, 2015
Closed
Closed
@pradithahidayat
Copy link

Can anyone give the examples about this features..?
Both of single and multiple upload..

I only get this reference:
https://github.com/marmelab/ng-admin/blob/master/doc/Configuration-reference.md#file-field-type

and I have no idea how to use multiple upload.

Also I have an issue, I must do a double click on Browse button to open the file selector.

Thanks..

@jeromemacias
Copy link
Contributor Author

Can you open an issue please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeromemacias @fzaninotto @pradithahidayat @gregbiv