Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Catalan translation repository #5245

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Conversation

joshf
Copy link
Contributor

@joshf joshf commented Sep 12, 2020

Add new links for spanish and catalan

Add new links for spanish and catalan
@fzaninotto
Copy link
Member

What's different in these packages from the old translations? Why did you develop new translations instead of fixing the ones in the existing packages?

@joshf
Copy link
Contributor Author

joshf commented Sep 14, 2020

Mainly because these packages were not updated very frequently, so sending pull requests there I think would have gone un noticed

@WiXSL
Copy link
Contributor

WiXSL commented Sep 14, 2020

I allways pull request translations and they respond pretty quickly

@Luwangel
Copy link
Contributor

@joshf Thanks for your contribution.

I think the Spanish repository is maintained and if you submit a pull request, the BlackBoxVision team will merge it. But I agree with you about the Catalan one. It seems to be old and I think it's better to replace it with your repository.

Could you update your PR by removing the Spanish line (and submit a PR it in the BlackBoxVision repository)?

docs/Translation.md Outdated Show resolved Hide resolved
@joshf
Copy link
Contributor Author

joshf commented Sep 14, 2020

This is kind of my point, for example is the correct one for spanish @WiXSL or @BlackBoxVision? Which one is the correct one to send a request too?

@WiXSL
Copy link
Contributor

WiXSL commented Sep 14, 2020

The correct one is BlackBoxVision for Spanish.

Co-authored-by: Adrien Amoros <adrien.amoros@gmail.com>
@joshf
Copy link
Contributor Author

joshf commented Sep 14, 2020

done, submited my changes to them

Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@Luwangel Luwangel added this to the 3.8.5 milestone Sep 15, 2020
@Luwangel Luwangel added documentation RFR Ready For Review labels Sep 15, 2020
@Luwangel Luwangel changed the title Update Translation.md Change the Catalan translation repository Sep 15, 2020
@Luwangel Luwangel merged commit d1aef1d into marmelab:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants