Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Fix type mismatch error on title prop for page components #6351

Merged
merged 1 commit into from
Jun 11, 2021
Merged

[TypeScript] Fix type mismatch error on title prop for page components #6351

merged 1 commit into from
Jun 11, 2021

Conversation

megantaylor
Copy link
Contributor

closes: #6350

adds false to title types for Create, Edit and Show components to match title type on List component (was added here: #6119)

djhi
djhi approved these changes Jun 11, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 3.16.1 milestone Jun 11, 2021
@fzaninotto fzaninotto changed the title update title prop type to prevent type mismatch [TypeScript] Fix type mismatch error on title prop for page components Jun 11, 2021
@fzaninotto fzaninotto merged commit b9c678e into marmelab:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.1
Development

Successfully merging this pull request may close these issues.

title type mismatch between ListProps and EditProps, CreateProps, ShowProps
3 participants
@megantaylor @djhi @fzaninotto