Skip to content

Conversation

le0nik
Copy link
Contributor

@le0nik le0nik commented Aug 22, 2016

It works by adding height property with the className value to the transitionName object.

<ReactCSSTransitionReplace transitionName={{ height: 'cross-fade-height' }}>
  <div key="page01">
    My page 01 content
  </div>
</ReactCSSTransitionReplace>

@le0nik
Copy link
Contributor Author

le0nik commented Sep 11, 2016

Nevermind. I'm maintaining my own fork of this module now: https://github.com/le0nik/react-css-transition-replace-plus

@le0nik le0nik closed this Sep 11, 2016
@marnusw marnusw reopened this Sep 14, 2016
@marnusw marnusw merged commit 8b42fff into marnusw:master Sep 14, 2016
@marnusw
Copy link
Owner

marnusw commented Sep 14, 2016

@le0nik you've done some great work on this module! Thanks for all that.

I'm sorry that I wasn't able to get round to it sooner. Everything you've done is now incorporated in this main repo and published as v2.0.0 and I've take care to maintain you as the author on your commits.

It would be a pity to see this module diverge into different packages unnecessarily, so if you want to make large scale changes/additions again in the future and aren't set on maintaining your own fork let me know and I'll make you a collaborator on this repo/npm.

@le0nik
Copy link
Contributor Author

le0nik commented Sep 14, 2016

I'm glad you're back!

I've added a deprecation notice to README.md and deprecated the package on npm.

Thanks for taking the time to incorporate the changes into this repo.

@marnusw
Copy link
Owner

marnusw commented Sep 14, 2016

No problem, and thanks for deprecating the other. Next time I'll be sure to at least leave a reply sooner! Funny how PRs always seem to arise in the most hectic times. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants