Skip to content

Fix 'attempt to subtract with overflow' if publish_time from Pyth is … #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix 'attempt to subtract with overflow' if publish_time from Pyth is … #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions contracts/oracle/osmosis/src/price_source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,18 +707,17 @@ impl OsmosisPriceSourceChecked {
let price_feed_response = query_price_feed(&deps.querier, contract_addr, price_feed_id)?;
let price_feed = price_feed_response.price_feed;

// Get the current price and confidence interval from the price feed
let current_price = price_feed.get_price_unchecked();

// Check if the current price is not too old
if (current_time - current_price.publish_time as u64) > max_staleness {
let current_price_opt =
price_feed.get_price_no_older_than(current_time as i64, max_staleness);
let Some(current_price) = current_price_opt else {
return Err(InvalidPrice {
reason: format!(
"current price publish time is too old/stale. published: {}, now: {}",
current_price.publish_time, current_time
price_feed.get_price_unchecked().publish_time, current_time
),
});
}
};

// Check if the current price is > 0
if current_price.price <= 0 {
Expand Down