Skip to content

[master] Fix: Use NeutronMsg::IbcTransfer for neutron reward collector #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2023
Merged

[master] Fix: Use NeutronMsg::IbcTransfer for neutron reward collector #269

merged 1 commit into from
Jul 26, 2023

Conversation

pacmanifold
Copy link
Contributor

No description provided.

apollo-sturdy
apollo-sturdy reviewed Jul 21, 2023
View reviewed changes
apollo-sturdy
apollo-sturdy reviewed Jul 21, 2023
View reviewed changes
apollo-sturdy
apollo-sturdy reviewed Jul 21, 2023
View reviewed changes
apollo-sturdy
apollo-sturdy approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@apollo-sturdy apollo-sturdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See comments for questions and suggestions

piobab
piobab requested changes Jul 23, 2023
View reviewed changes
piobab
piobab reviewed Jul 24, 2023
View reviewed changes
@piobab
Copy link
Collaborator

piobab commented Jul 24, 2023

Tests are only for Osmosis but they cover most of the logic. Ideally we move common test to rewards-collector/test directory and chain specific to rewards-collector-osmosis/tests and rewards-collector-neutron/tests but I suppose this requires more time to do it.

@piobab piobab force-pushed the fix/neutron-ibc-msg branch from a0001fc to 281a459 Compare July 24, 2023 09:53
@grod220
Copy link
Contributor

grod220 commented Jul 24, 2023

Besides Piotr's comments, I didn't find anything additional. Good job!

@piobab piobab self-requested a review July 26, 2023 15:02
@pacmanifold @piobab
Move rewards collector to rewards collector base
69c8400 
Move tests from base to osmosis

Implement IbcTransferMsg abstraction

Implement mars-rewards-collector-neutron

Add neutron config to update msg.

Disable github pipeline.
@piobab piobab force-pushed the fix/neutron-ibc-msg branch from c529fa9 to 69c8400 Compare July 26, 2023 20:09
@piobab
Copy link
Collaborator

piobab commented Jul 26, 2023

Squashed 10 commits to one clean msg.

@piobab piobab changed the title Fix: Use NeutronMsg::IbcTransfer for neutron reward collector [master] Fix: Use NeutronMsg::IbcTransfer for neutron reward collector Jul 26, 2023
@piobab piobab merged commit a0b66d3 into master Jul 26, 2023
@piobab piobab mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piobab piobab piobab approved these changes

@dancreee dancreee dancreee approved these changes

+1 more reviewer

@apollo-sturdy apollo-sturdy apollo-sturdy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pacmanifold @piobab @grod220 @dancreee @apollo-sturdy