Skip to content

Conversation

piobab
Copy link
Collaborator

@piobab piobab commented Jul 24, 2023

  • liquidation with simplified protocol fee as part of total liquidation bonus
  • improved test cases (used multi-test)
  • move liquidate to separate file (in next PR I will do the same for deposit, withdraw etc)

@piobab piobab requested review from brimigs and grod220 July 24, 2023 21:35
@piobab piobab force-pushed the MP-3123-new-dynamic-liquidation branch from 26c3a6e to 58a1756 Compare July 24, 2023 21:37
Copy link
Contributor

@brimigs brimigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update all the types in the deploy scripts but we can just add that to the bulleted list in the upcoming build scripts jira ticket

Copy link
Contributor

@brimigs brimigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also looks like we'll need to update the github actions for running tests: https://stackoverflow.com/questions/28124221/error-linking-with-cc-failed-exit-code-1

@piobab
Copy link
Collaborator Author

piobab commented Jul 25, 2023

It also looks like we'll need to update the github actions for running tests: https://stackoverflow.com/questions/28124221/error-linking-with-cc-failed-exit-code-1

Problem is more complex:

note: /usr/bin/ld: final link failed: No space left on device
          collect2: error: ld returned 1 exit status

@piobab piobab force-pushed the MP-3123-new-dynamic-liquidation branch 2 times, most recently from 2502740 to 006143e Compare July 25, 2023 08:52
@piobab piobab force-pushed the MP-3123-new-dynamic-liquidation branch from 006143e to a04c4ad Compare July 25, 2023 09:04
Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worthwhile exporting to a package now versus later. What do you think?

@piobab piobab requested a review from grod220 July 25, 2023 11:55
Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the tests live in the liquidation package? Not sure, but that's my only additional thought. Good job!

@piobab piobab force-pushed the MP-3123-new-dynamic-liquidation branch from 197da6f to 910de65 Compare July 25, 2023 13:32
@piobab piobab force-pushed the MP-3123-new-dynamic-liquidation branch from 910de65 to e761138 Compare July 25, 2023 13:39
@piobab piobab merged commit 5121717 into develop Jul 25, 2023
@piobab piobab deleted the MP-3123-new-dynamic-liquidation branch July 25, 2023 18:21
brimigs pushed a commit that referenced this pull request Jul 31, 2023
* New dynamic liquidation mechanics.

* Extract liquidation to sperate crate.

* Disable test coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants