-
Notifications
You must be signed in to change notification settings - Fork 22
New dynamic liquidation mechanics. #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
piobab
commented
Jul 24, 2023
- liquidation with simplified protocol fee as part of total liquidation bonus
- improved test cases (used multi-test)
- move liquidate to separate file (in next PR I will do the same for deposit, withdraw etc)
26c3a6e
to
58a1756
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to update all the types in the deploy scripts but we can just add that to the bulleted list in the upcoming build scripts jira ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also looks like we'll need to update the github actions for running tests: https://stackoverflow.com/questions/28124221/error-linking-with-cc-failed-exit-code-1
Problem is more complex:
|
2502740
to
006143e
Compare
006143e
to
a04c4ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worthwhile exporting to a package now versus later. What do you think?
contracts/red-bank/tests/files/Red Bank - Dynamic LB & CF test cases v1.1.xlsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the tests live in the liquidation package? Not sure, but that's my only additional thought. Good job!
197da6f
to
910de65
Compare
910de65
to
e761138
Compare
* New dynamic liquidation mechanics. * Extract liquidation to sperate crate. * Disable test coverage.