Skip to content

MP-2615 rover rewards #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2023
Merged

MP-2615 rover rewards #273

merged 3 commits into from
Jul 26, 2023

Conversation

piobab
Copy link
Collaborator

@piobab piobab commented Jul 25, 2023

Add support to track rover account ids in deposit/withdraw

Note: All migration for red bank will go in separate PR.

@piobab piobab changed the base branch from master to develop July 25, 2023 20:11
piobab
piobab commented Jul 25, 2023
View reviewed changes
@piobab piobab requested review from brimigs and grod220 July 25, 2023 21:16
grod220
grod220 reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are usages in the contracts where account ID is assumed to be "". I wonder if that poses safety issues. Shouldn't all of those function signatures accept account_id now?

@piobab
Copy link
Collaborator Author

piobab commented Jul 26, 2023

There are usages in the contracts where account ID is assumed to be "". I wonder if that poses safety issues. Shouldn't all of those function signatures accept account_id now?

Unfortunatelly not, we have Red Bank users and rover accounts.

@piobab piobab requested a review from grod220 July 26, 2023 13:09
@piobab piobab merged commit 4cd795c into develop Jul 26, 2023
@piobab piobab deleted the feature/MP-2615-rover-rewards branch July 26, 2023 14:35
larry0x pushed a commit that referenced this pull request Aug 1, 2023
@piobab @larry0x
MP-2615 rover rewards (#273)
f974563 
* Add account_id for rover deposit rewards.

* Use user addr and account id as compound key.

* Apply comments.
larry0x pushed a commit that referenced this pull request Aug 1, 2023
@piobab @larry0x
MP-2615 rover rewards (#273)
812364b 
* Add account_id for rover deposit rewards.

* Use user addr and account id as compound key.

* Apply comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@grod220 grod220 grod220 approved these changes

@brimigs brimigs brimigs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piobab @grod220 @brimigs