Skip to content

Use cosmwasm_std::Coins in the accounting of unclaimed rewards #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

Use cosmwasm_std::Coins in the accounting of unclaimed rewards #281

merged 1 commit into from
Jul 31, 2023

Conversation

larry0x
Copy link
Contributor

@larry0x larry0x commented Jul 30, 2023

this avoids generating a BankMsg::Send that contains coins with zero amounts.

larry0x
larry0x commented Jul 30, 2023
View reviewed changes
larry0x
larry0x commented Jul 30, 2023
View reviewed changes
@dancreee dancreee requested a review from piobab July 30, 2023 16:13
piobab
piobab reviewed Jul 30, 2023
View reviewed changes
@piobab
Copy link
Collaborator

piobab commented Jul 30, 2023

@larry0x one comment. We can't squash/rebase merge. Please squash everything to one commit and the just MERGE so we can then do git merge develop -> solve connflicts and merge to develop branch.

@larry0x larry0x force-pushed the coins branch 3 times, most recently from bf33c51 to a46afb2 Compare July 30, 2023 18:28
@piobab piobab merged commit ac94611 into master Jul 31, 2023
@piobab piobab mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piobab piobab piobab approved these changes

@dancreee dancreee dancreee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larry0x @piobab @dancreee