MP-3299, Oak no. 8, contract version update. MP-3310, Oak no. 19, provide whitelist count. #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piobab
changed the title
dancreee
approved these changes
Aug 31, 2023
|
I am closing this PR. It is incomplete -> incentives state changed and it requires more state migration. It will be handled in separate PR. Fix for whitelist extracted here #316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incentive contract inherits the version of the workspace in red-bank:Cargo.toml. During initialization, the version is indeed set correctly. However, during migration, the contract version is not updated in red-bank:contracts/incentives/src/contract.rs:767-769.
This could lead to confusion during future migrations as it will not be possible to be certain which version of the contract is deployed in production.