MP-3299. Oak no. 8. #317
Merged
MP-3299. Oak no. 8. #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piobab
commented
Sep 5, 2023
| // Get asset incentive for a denom. It should be available but just in case we don't unwrap | ||
| let denom_idx = asset_incentives.get(&denom); | ||
| if let Some(asset_incentive) = denom_idx { | ||
| // Since we didn't track unclaimed rewards per collateral denom in v1 we add them |
There was a problem hiding this comment.
We can send these rewards to user wallets but I am not sure if this is good decision. For now I add unclaimed rewards from previous state to first user collateral denom.
piobab
force-pushed
the
fix/MP-3299-oak-8
branch
from
764606a to
561ef8c
Compare
|
Pushed fix for schema. Problem: Even with specifying versions. Clean & build. Regenerating Cargo.lock etc - nothing helped. |
thec00n
reviewed
Sep 7, 2023
| .collect::<StdResult<HashMap<_, _>>>()?; | ||
| v1_state::USER_UNCLAIMED_REWARDS.clear(deps.storage); | ||
|
|
||
| for ((user, denom), user_asset_index) in user_asset_indices { |
There was a problem hiding this comment.
Are we hitting block gas limit here if there are too many users?
There was a problem hiding this comment.
Could be. We will see once we try to migrate the contracts on devnet
dancreee
approved these changes
Sep 7, 2023
|
lgtm, pretty complex migration :) lets see about gas as theC00n brings up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oak no. 8. requires only version fix during migration but there is much more migration needed after neutron
incentiveschanges.