MP-3345. MP-3348. Don't allow red-bank users to create alternative account ids. #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR to revert-deposit-on-behalf-of. Once that branch is merged I will change destination to |
thec00n
approved these changes
Sep 11, 2023
piobab
force-pushed
the
fix/MP-3345-acc-id-allowed-only-for-cm
branch
from
c906aa2 to
8bade3d
Compare
piobab
changed the base branch from
revert-deposit-on-behalf-of
to
release/mars-v2
|
Changed destination branch. Pushed rebased commit with latest changes from release/mars-v2 |
dancreee
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to @thec00n findings:
no. 1 (red-bank users with alternative account ids might not be able to withdraw their funds).
Do not allow red-bank users to create alternative account ids only allow the credit manager to create them by only allowing the credit manager contract to interact with the deposit and withdraw endpoint.
no. 4 (account_id is not validated in red-bank)
red-bank should not allow users to create account-ids directly and any action should use the default account “”. Only the credit manager should be allowed to create custom account ids because validation is performed for all actions.