-
Notifications
You must be signed in to change notification settings - Fork 22
Merge contents of rover
repo into red-bank
repo
#335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
change stuff
Adding allow-list for vaults and assets
* Use paginated UserCollateralsV2 query for lents. * Add tests. * Update schema.
Fix Protocol Liquidation Fee calculation.
Oak 7. Remove rewards-collector setup in migration.
* Add credit manager add to health contract instantiation. * Add nicer msg if no cm set.
* Don't check HF for deposit and repay. * Update schema. * Assert errors it comes from price query for HF.
* Specify account kind for health response. * Extract account-nft types to avoid circular dependency. * Add tests for AccountKind query in account-nft contract. * Use closure. * Update schema. * Update comment.
* Withdraw coins after claiming rewards for HLS account. * Update schema. * Review comments. * Fmt
* Add max_slippage config. * Use slippage for ProvideLiquidity and WithdrawLiquidity. * Assert slippage in swap. * Update scripts. * Update error msg.
* New devnet deployment. * New Addrs and fixes to deployment. * Create new deployment with TWAP. Gran credit line for CM. * New devnet deployment with Pyth setup. * Fmt * Fix max_slippage config. * New deployment. * Update red-bank dep to latest master commit.
* Migrate zapper contract. * Fix zapper naming. * Migrate red-bank state in CM.
* Clear empty accounts. * Update schema. * Add tests. Cleanup. * Improve msg. * Update CM with rc. New deployment.
Getting "No space left on device" error for coverage |
It might be unnecessary to merge the rover and redbank deploy scripts together into one, but we could unify them somehow so that we can deploy everything with on command. |
We have two options:
We already decided to go with option 1) for red-bank so maybe we should do it for whole repo the same way, thoughts @larry0x @dancreee ? |
PR is difficult to review :D so better to check diff between rover repo latest commit (mars-protocol/rover@1176c73) and current branch commit bebf5cc |
agree if it's practical to do this |
All tests passed for me locally, except for:
It is related to
Once we extract msgs to types we can remove feature flag and tests should pass. Moreover we are going to solve |
Commands I used to prepare this PR:
I don't have a good idea how to merge the deployment scripts. For now I simply rename the files (e.g.
deploy.ts
in the Rover repo is nowdeploy.rover.ts
)