Skip to content

Conversation

larry0x
Copy link
Contributor

@larry0x larry0x commented Oct 12, 2023

Closes: #336

Create a mars-types crate as the single source of truth for all type definitions.

Three crates are merged into mars-types and deleted:

  • mars-account-nft-types
  • mars-rover-health-types
  • mars-rover

There are 3 instances of duplicate codes which have been fixed (leaving only one copy):

  • mars_rover::adapters::swap and mars_red_bank_types::swapper
  • mars_rover::reentrancy_guard and mars_utils::guard
  • mars_rover::msg and mars_red_bank_types::rewards_collector::credit_manager

The table below compares the previous locations of contents & their locations now:

Previous Now
mars_account_nft_types mars_types::account_nft
mars_params::types mars_types::params (#338)
mars_red_bank_types mars_types
mars_rover_health_types mars_types::health
mars_rover::adapters mars_types::adapters
mars_rover::coins deleted (use cosmwasm_std::Coins instead)
mars_rover::error mars_credit_manager::error
mars_rover::msg mars_types::credit_manager
mars_rover::reentrancy_guard deleted (use mars_utils::Guard instead)
mars_rover::traits mars_types::traits
mars_zapper_base::msg mars_types::zapper

@larry0x larry0x marked this pull request as ready for review October 12, 2023 11:05
Copy link
Collaborator

@piobab piobab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM

@larry0x larry0x merged commit edc74bf into master Oct 13, 2023
@larry0x larry0x deleted the mars-types branch October 14, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create mars-types and mars-adapters crates

2 participants