-
Notifications
You must be signed in to change notification settings - Fork 22
Create mars-types
crate
#339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larry0x
commented
Oct 12, 2023
larry0x
commented
Oct 12, 2023
larry0x
commented
Oct 12, 2023
piobab
reviewed
Oct 13, 2023
piobab
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #336
Create a
mars-types
crate as the single source of truth for all type definitions.Three crates are merged into
mars-types
and deleted:mars-account-nft-types
mars-rover-health-types
mars-rover
There are 3 instances of duplicate codes which have been fixed (leaving only one copy):
mars_rover::adapters::swap
andmars_red_bank_types::swapper
mars_rover::reentrancy_guard
andmars_utils::guard
mars_rover::msg
andmars_red_bank_types::rewards_collector::credit_manager
The table below compares the previous locations of contents & their locations now:
mars_account_nft_types
mars_types::account_nft
mars_params::types
mars_types::params
(#338)mars_red_bank_types
mars_types
mars_rover_health_types
mars_types::health
mars_rover::adapters
mars_types::adapters
mars_rover::coins
cosmwasm_std::Coins
instead)mars_rover::error
mars_credit_manager::error
mars_rover::msg
mars_types::credit_manager
mars_rover::reentrancy_guard
mars_utils::Guard
instead)mars_rover::traits
mars_types::traits
mars_zapper_base::msg
mars_types::zapper