This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
Fix schema with relationship to dump None #302
Merged
sloria
merged 5 commits into
marshmallow-code:dev
from
mahenzon:fix-relationship-field-dump-none
Dec 27, 2020
Merged
Fix schema with relationship to dump None #302
sloria
merged 5 commits into
marshmallow-code:dev
from
mahenzon:fix-relationship-field-dump-none
Dec 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahenzon
commented
Apr 21, 2020
ouch, tests failed. do you really still support marshmallow 2? ok then, I'll make the test compatible.. |
mahenzon
force-pushed
the
fix-relationship-field-dump-none
branch
from
April 21, 2020 17:16
cda8f49
to
1db3eea
Compare
mahenzon
changed the title
Fix schema with relationship dump None
Fix schema with relationship to dump None
Apr 21, 2020
iamareebjamal
approved these changes
Dec 26, 2020
Ping @sloria |
sloria
reviewed
Dec 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this. Looks good. I'll go ahead and update this with the latest dev
.
woodb
pushed a commit
to DataDog/marshmallow-jsonapi
that referenced
this pull request
May 13, 2022
* Fix schema with relationship to dump None * Revert gitignore change (.idea belongs in global gitignore) * Fix test * Update changelog Co-authored-by: Steven Loria <sloria1@gmail.com>
woodb
pushed a commit
to DataDog/marshmallow-jsonapi
that referenced
this pull request
May 16, 2022
* Fix schema with relationship to dump None * Revert gitignore change (.idea belongs in global gitignore) * Fix test * Update changelog Co-authored-by: Steven Loria <sloria1@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #278
When
None
is passed to a schema, which contains relationships, it fails. Though on the previous versions it successfully returned data. That's because of direct use ofself._serialize
. The check for missing fields just doesn't happen.If you try to run the new test, it will fail with this text: