Skip to content

Conversation

ddobson
Copy link
Contributor

@ddobson ddobson commented Jul 23, 2020

Hey there! First let me say thank you for all the awesome improvements and maintenance this team has done with the original code base. My team has chosen to use this fork for a new project, but we quickly noticed that our nested schema validation errors were not correct. After some digging I discovered that the issue was actually with marshmallow-jsonapi (see marshmallow-code/marshmallow-jsonapi#120). This PR bumps the version of the dependency with all changes detailed below. Cheers!

This version bump includes:

@ddobson
Copy link
Contributor Author

ddobson commented Jul 23, 2020

Just realized that this change has broken the test suite in Travis, however, locally all of my tests are passing on Python 3.7. I will try to dig into the code a bit more when I get a little free time.

@iamareebjamal
Copy link
Contributor

0.24.0 should work now

@ddobson ddobson closed this Jan 2, 2021
@ddobson ddobson reopened this Mar 3, 2021
ddobson added 3 commits March 3, 2021 09:03
This version bump includes:
- 0.23.2 Import from collections.abc for forward-compatibility with Python 3.10
- 0.23.1 Fix nested fields validation error formatting
- 0.23.0 Improve performance of link generation
@coveralls
Copy link

Pull Request Test Coverage Report for Build 67

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.909%

Totals Coverage Status
Change from base Build 51: 0.0%
Covered Lines: 1271
Relevant Lines: 1533

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 3, 2021

Pull Request Test Coverage Report for Build 67

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.909%

Totals Coverage Status
Change from base Build 51: 0.0%
Covered Lines: 1271
Relevant Lines: 1533

💛 - Coveralls

@ddobson ddobson changed the title Update marshmallow_jsonapi version to 0.23.2 Update marshmallow_jsonapi version to 0.24.0 Mar 4, 2021
@dmitrymishanov dmitrymishanov merged commit 2839134 into AdCombo:develop Apr 14, 2021
@dmitrymishanov
Copy link
Contributor

@ddobson Thanks :)
Merged your PR

@ddobson ddobson deleted the bump-marshmallow-jsonapi-version branch April 14, 2021 14:13
@mahenzon
Copy link
Collaborator

hehe just noticed this

2/4 of fixes are my PR's 🌚 . We needed those fixes at AdCombo too

Thanks for your kind words @ddobson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants