Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tauri][wip] Fix theme integration #759

Closed
wants to merge 1 commit into from
Closed

[Tauri][wip] Fix theme integration #759

wants to merge 1 commit into from

Conversation

martpie
Copy link
Owner

@martpie martpie commented Mar 20, 2024

do not merge. not ready. code sucks. the whole process sucks. I have to draw a flow chart from scratch.

I need to move that code to a single-direction-data-flow.

What we need to reimplement:

  • Museeks 0.13 behavior, but for Tauri
    • "System" theme
      • Window theme is correctly set (already done by Tauri, when theme is None)
        • [hard] While making explicit light/dark initial window theme work
      • Update theme based on the ThemeChanged event
    • "Dark" or "Light" theme
      • Set dark/light window theme on startup
      • Set dark/light app content theme on startup
      • [hard] Update window theme at runtime when user selects a new theme

@martpie martpie marked this pull request as draft March 20, 2024 15:32
@@ -14,8 +14,6 @@
"label": "main",
"title": "Museeks",
"visible": false,
"hiddenTitle": true,
"titleBarStyle": "Overlay",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove that after testing

@martpie martpie marked this pull request as ready for review March 20, 2024 21:34
@martpie martpie changed the title [Tauri] Fix theme integration [Tauri][wip] Fix theme integration Mar 20, 2024
Base automatically changed from tauri to master June 13, 2024 18:34
@martpie
Copy link
Owner Author

martpie commented Nov 3, 2024

Actually already fixed

@martpie martpie closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant