Fix build with GCC 8.2.0 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooh, thanks @shdnx! Could you also make the same changes in the single-header version, toml.hpp? Either manually, or using the python script (see Regenerating toml.hpp in CONTRIBUTING). |
|
(side note: CircleCI should have run checks against this PR, and the fact that it didn't means I've misconfigured it somehow. Guess I should investigate that.) |
|
@marzer Sorry about that, I fixed it there as well now! |
|
Nice work, thanks @shdnx |
|
@marzer Thank you for the quick reaction! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, GCC 8.2.0's glibc has the pre-c++11 overloads of
std::string::erase()which take a non-const iterator. This change fixes building on that compiler, and should also work on later versions (tested with Clang 9.0.1).