Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create specific KNetCore implementation for each application #136

Closed
masesdevelopers opened this issue Nov 22, 2022 · 0 comments · Fixed by #137
Closed

Create specific KNetCore implementation for each application #136

masesdevelopers opened this issue Nov 22, 2022 · 0 comments · Fixed by #137
Assignees
Labels
enhancement New feature or request KNet KNet related issue KNetCLI KNetCLI related issue KNetPS KNetPS related issue KNetTemplates KNet Templates related issue

Comments

@masesdevelopers
Copy link
Contributor

    To fulfill the request we are changing the class chain:
  • KNetCLI will have its own implementation of KNetCore<T>: the specific section of KNetCore<T> will be moved in the CLI implementation; this instance will not manage the Connect tools
  • KNetPS will have its own implementation of KNetCore<T>: it will be a copy of the one in CLI
  • KNetConnect will have its own implementation of KNetCore<T>managing only the Apache Kafka Connect with different command-line arguments:
    • instead to request ClassToRun with a value of ConnectDistributed or ConnectStandalone, the command-line interface will use d and s switches

Originally posted by @masesdevelopers in #135 (comment)

@masesdevelopers masesdevelopers added enhancement New feature or request KNet KNet related issue KNetCLI KNetCLI related issue KNetPS KNetPS related issue KNetTemplates KNet Templates related issue labels Nov 22, 2022
@masesdevelopers masesdevelopers self-assigned this Nov 22, 2022
masesdevelopers added a commit that referenced this issue Nov 22, 2022
* #136: removed KNetCore from KNet and created specific version on each executable

* #136: KNetPS and KNetCLI can share a base extension of KNetCore
masesdevelopers added a commit that referenced this issue Nov 23, 2022
* #136: fix release workflow

* Update Code-QL too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request KNet KNet related issue KNetCLI KNetCLI related issue KNetPS KNetPS related issue KNetTemplates KNet Templates related issue
Projects
None yet
1 participant