Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create specific KNetCore implementation for each application #137

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Create specific KNetCore implementation for each application #137

merged 3 commits into from
Nov 22, 2022

Conversation

masesdevelopers
Copy link
Contributor

Description

As requested from #136 KNetCore was removed from KNet.dll assembly and implemented per application bases. This is a breaking change for anyone is using the library.

Related Issue

Closed #136

Motivation and Context

How Has This Been Tested?

Not tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added enhancement New feature or request KNet KNet related issue KNetCLI KNetCLI related issue KNetPS KNetPS related issue KNetTemplates KNet Templates related issue labels Nov 22, 2022
@masesdevelopers masesdevelopers self-assigned this Nov 22, 2022
@masesdevelopers masesdevelopers changed the title Create specific knetcore implementation for each application Create specific KNetCore implementation for each application Nov 22, 2022
@masesdevelopers masesdevelopers merged commit 4674703 into masesgroup:master Nov 22, 2022
@masesdevelopers masesdevelopers deleted the 136-create-specific-knetcore-implementation-for-each-application branch November 22, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request KNet KNet related issue KNetCLI KNetCLI related issue KNetPS KNetPS related issue KNetTemplates KNet Templates related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create specific KNetCore implementation for each application
1 participant