Skip to content
This repository has been archived by the owner on Sep 22, 2024. It is now read-only.

Updating logging code to what @Fy0urM suggested & Fix grammar & Remove Clone Army #211

Closed
wants to merge 63 commits into from

Conversation

tboy1337
Copy link
Contributor

@tboy1337 tboy1337 changed the title Updating loggin code to what @Fy0urM suggested Updating logging code to what @Fy0urM suggested Aug 22, 2024
@masterking32
Copy link
Owner

Why do we need to save logs in a file when we already have a Telegram log? The Telegram log isn't easily usable for everyone.

@Pawansingh333
Copy link

Why do we need to save logs in a file when we already have a Telegram log? The Telegram log isn't easily usable for everyone.

yes you are right

@tboy1337
Copy link
Contributor Author

Why do we need to save logs in a file when we already have a Telegram log? The Telegram log isn't easily usable for everyone.

I dont use telegram and would prefer local logs and since there is already code in main.py for local logging which doesnt work it makes sense to fix it.

@tboy1337 tboy1337 changed the title Updating logging code to what @Fy0urM suggested Updating logging code to what @Fy0urM suggested + Adding new playground games Aug 23, 2024
@tboy1337 tboy1337 changed the title Updating logging code to what @Fy0urM suggested + Adding new playground games Updating logging code to what @Fy0urM suggested & Adding new playground games Aug 23, 2024
@Fy0urM
Copy link
Contributor

Fy0urM commented Aug 23, 2024

an attempt to push logging into a file?)))
you can make changes to the file yourself, but it will have to be done every time the bot is updated, not very convenient. i have half the script in modifications))

@tboy1337 tboy1337 changed the title Updating logging code to what @Fy0urM suggested & Adding new playground games Updating logging code to what @Fy0urM suggested Aug 23, 2024
@tboy1337
Copy link
Contributor Author

output.log still has ANSI escape codes but at least its producing a .log file.

@tboy1337
Copy link
Contributor Author

tested fully working, thanks @Fy0urM

@tboy1337 tboy1337 changed the title Updating logging code to what @Fy0urM suggested Updating logging code to what @Fy0urM suggested & Fix grammar & Remove Clone Army Aug 26, 2024
@tboy1337
Copy link
Contributor Author

tboy1337 commented Aug 26, 2024

Logging code now working in main, grammar fixed in README and Clone Army removed from promogames, please merge @masterking32.

@tboy1337 tboy1337 mentioned this pull request Aug 26, 2024
@masterking32
Copy link
Owner

Logging code now working in main, grammar fixed in README and Clone Army removed from promogames, please merge @masterking32.

You need to create a separate PR for each feature you add. Please don't include all of them in a single pull request, as it makes it difficult to select or merge individual features. Additionally, I don't believe everyone needs a log file. For some, including myself, it could result in a large, unnecessary file. The current log system is intended for display purposes only, so it's not essential for everyone. For other features, please submit separate PRs. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants