-
Notifications
You must be signed in to change notification settings - Fork 89
Updating logging code to what @Fy0urM suggested & Fix grammar & Remove Clone Army #211
Conversation
Why do we need to save logs in a file when we already have a Telegram log? The Telegram log isn't easily usable for everyone. |
yes you are right |
I dont use telegram and would prefer local logs and since there is already code in main.py for local logging which doesnt work it makes sense to fix it. |
an attempt to push logging into a file?))) |
output.log still has ANSI escape codes but at least its producing a .log file. |
tested fully working, thanks @Fy0urM |
Logging code now working in main, grammar fixed in README and Clone Army removed from promogames, please merge @masterking32. |
You need to create a separate PR for each feature you add. Please don't include all of them in a single pull request, as it makes it difficult to select or merge individual features. Additionally, I don't believe everyone needs a log file. For some, including myself, it could result in a large, unnecessary file. The current log system is intended for display purposes only, so it's not essential for everyone. For other features, please submit separate PRs. Thanks. |
#147