Change import of AtomiInteger in SpotTrackIDFeatureComputer #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While searching for a method that can directly compute the distance between 2 spots in the Mastodon code base, I found the distance method in this class. Later, I learned that there is the same method in imglib2. In order to simplify the code I suggest to replace this re-implementation by using the imglib2 version of this method.
… the BDV views of Mastodon
…icInteger to java.util.concurrent.atomic.AtomicInteger; * The import of io.humble.ferry.AtomicInteger creates an unnecessary dependency on humble video library * The java.util.concurrent.atomic.AtomicInteger which is part of java is sufficient in this this class
|
Shall we merge it to |
tinevez
approved these changes
Feb 21, 2024
I would prefer merging to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #280