Quick rearrange for ES_PRESET, add to values file #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
reviewed
Jan 19, 2024
| ES_HOST: {{ template "mastodon.elasticsearch.fullname" . }}-master-hl | ||
| ES_PORT: "9200" | ||
| {{- else if .Values.elasticsearch.hostname }} | ||
| ES_ENABLED: "true" | ||
| ES_PRESET: {{ .Values.elasticsearch.preset | default "single_node_cluster" | quote }} |
There was a problem hiding this comment.
You should be able to define this variable is ES is enabled, wether it is through elasticsearch.enabled or with elasticsearch.hostname defined
There was a problem hiding this comment.
Yeah that makes sense. Fixed.
renchap
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a quick rearrange of a PR I just merged (add
ES_PRESETas an option invalues.yamlas the original merge with an outdated branch was a little clunky and resulted in some duplicated lines + not ideal placement.