-
-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiles filter context missing #1355
base: main
Are you sure you want to change the base?
Profiles filter context missing #1355
Conversation
@JakePaustianISU is attempting to deploy a commit to the Mastodon Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably also need to update the screenshots on this page since elements have changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but as stated in the PR, this page would benefit from updated images as well.
@@ -35,6 +35,7 @@ Choose where the filter will be applied: | |||
* Notifications = matching notifications will not be shown | |||
* Public timelines = matching statuses will not appear in local/federated timelines | |||
* Conversations = matching statuses will be hidden in threads and detailed views | |||
* Profiles = matching profiles will be hidden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matching profiles will be hidden
-> matching statuses will be hidden in profile views
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would be a better way of phrasing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest updating the language per comments in the review.
@@ -35,6 +35,7 @@ Choose where the filter will be applied: | |||
* Notifications = matching notifications will not be shown | |||
* Public timelines = matching statuses will not appear in local/federated timelines | |||
* Conversations = matching statuses will be hidden in threads and detailed views | |||
* Profiles = matching profiles will be hidden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would be a better way of phrasing it.
Trys to address issue #1332