This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Add tests for websocket routes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors how SSE requests are handled to bring them into line with how WS requests are handled and increase consistency.
Bump version and update name from ragequit to flodgatt.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the websocket routes. In combination with #37, this closes #27—all tests have now been replaced with unit tests. Specifically, every flodgatt contains 54 tests that test every possible route, both SSE and WS. These tests ensure that each request is either rejected (if not authorized) or is correctly parsed into a
Userthat is passed on toClientAgent.We do not yet have tests for the functionality in the
ClientAgentorReceiver—that is, we aren't testing what we do with theUseronce it is generated. But that is the obvious next step in increasing testing coverage.