Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3: Add labels to the bottom navigation bar and maybe fill the icons #614

Closed
HonbraDev opened this issue Jul 1, 2023 · 12 comments
Closed

Comments

@HonbraDev
Copy link

Currently, apps using the bottom bar have labels under the icons by default. This app does not. While it is a valid UX decision, it would be nice to have an option to turn them back on and/or annotate them when long-pressing.

The current bottom navigation bar, which is shorter than the default component and lacks labels:

described above

The demo component from the Material Gallery, which is taller than the Mastodon one and has labels on long press:

described above

The proposed configuration, with the label visibility option set to auto:

described above

The icons also don't switch to their filled variant when selected, though again this could be a valid UX decision.

@grishka
Copy link
Member

grishka commented Jul 1, 2023

Our UIs are designed by a professional design team. We don't accept outside contributions to the UI of the app.

@grishka grishka closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2023
@CherryKitten
Copy link

Our UIs are designed by a professional design team. We don't accept outside contributions to the UI of the app.

have you considered just making this closed source then? lol

@ShadowJonathan
Copy link

ShadowJonathan commented Feb 9, 2024

Our UIs are designed by a professional design team. We don't accept outside contributions to the UI of the app.

Y'know, the correct way to deal with issues like this is to pass that feedback onwards to that same design team, not to close the issue, since that's just putting fingers in your ears and going "lalalalala cant hear you", which isn't very appriciated in open source projects.

@cyrneko
Copy link

cyrneko commented Feb 9, 2024

Our UIs are designed by a professional design team. We don't accept outside contributions to the UI of the app.

Your professional design Team is actively ignoring the material design guidelines you're trying to follow.

the bottom tab bar should NEVER not have labels.

https://m3.material.io/components/navigation-bar/guidelines

@Kiloku
Copy link

Kiloku commented Feb 9, 2024

I recommend everyone use Megalodon, which is a fork of Mastodon for Android that actually is community focused. In fact, it already has labels for the bottom bar. Not sure if I can link it here, but it's easy to find.

@ashley-graves
Copy link

I recommend everyone use Megalodon, which is a fork of Mastodon for Android that actually is community focused. In fact, it already has labels for the bottom bar. Not sure if I can link it here, but it's easy to find.

https://github.com/sk22/megalodon

@LuNeder

This comment was marked as off-topic.

@KiitoX
Copy link

KiitoX commented Feb 9, 2024

It seems to me this decision is not compliant with written policy. This issue/feature request is plainly about accessibility, and as far as I can tell this only affects the Android version of this app.

image

This issue should at least be brought up to the design team, instead of closing it. Alternatively do us a favor and adjust that contribution policy, to reflect reality.

@flufferyomada

This comment was marked as off-topic.

@ahoneybun
Copy link

Another fediverse application doing this correctly per Material Design is Sync.

Screenshot_20240209-123658.png

@alkaris2

This comment was marked as abuse.

@Taureon

This comment was marked as abuse.

@mastodon mastodon locked as off-topic and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests