-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server Details in Settings (IOS-20) #1126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
force-pushed
the
ios-20-server-details
branch
3 times, most recently
from
October 9, 2023 12:07
7c78687
to
caf6369
Compare
APIService was missing and URL was wrong
This is kind of WIP as not the whole text is shown for unknown reasons
- Improve Image Download and add a placeholderimage - Fix dark mode colors - calculate header/footer-size based on the width of the table view (TIL!) - Remove some old assets
zeitschlag
force-pushed
the
ios-20-server-details
branch
from
October 10, 2023 11:56
e5b1303
to
2087c24
Compare
kimar
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @zeitschlag LGTM 🚀
Mastodon/Scene/Onboarding/ServerRules/Cell/ServerRulesTableViewCell.swift
Show resolved
Hide resolved
Mastodon/Scene/Settings/Server Details/AboutInstanceViewController.swift
Outdated
Show resolved
Hide resolved
Height is determined dynamically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to provide the user more information about their instance. That's why in the new settings, there's a section about exactly this. It's called ✨Server Details✨
We show the rules and the extended description so that they don't have to go to the website to see the responsible people. From this screen they also can send an email directly to their adminstrator(s).
Side Effects