Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification Filtering (IOS-241) #1319

Merged
merged 48 commits into from
Jul 26, 2024
Merged

Notification Filtering (IOS-241) #1319

merged 48 commits into from
Jul 26, 2024

Conversation

zeitschlag
Copy link
Contributor

@zeitschlag zeitschlag commented Jun 25, 2024 •
edited
Loading

  • Adds a new cell on the "Everything"-notification-screen to show unwanted notifications
  • Users can define what "unwanted" means to them using the new "Filter"-button in the upper right corner of the Notification-screen
  • Filtered notifications are sorted by account and users can dismiss/accept if they want to get notifications of that user (it's some standard table-views and delegates)

Screenshots

ios_241_1

ios_241_2

@zeitschlag zeitschlag self-assigned this Jun 25, 2024
@zeitschlag zeitschlag force-pushed the ios-241-notification-filtering branch from 18161cf to 32c356b Compare July 2, 2024 12:34
@zeitschlag zeitschlag force-pushed the ios-241-notification-filtering branch 3 times, most recently from 1023f1c to e104499 Compare July 19, 2024 07:25
@zeitschlag
Add notification-policy-download (IOS-241)
cf39ad6
@zeitschlag
Add a filtering-button that is only visible if there's a policy (IOS-241
3118861 
)
@zeitschlag
Fix detens (IOS-241)
f297cba
@zeitschlag
Add and show filter-banner in "everything"-notifications (if there ar…
4843348 
…e any) (IOS-241)
@zeitschlag
Add basic UI filter notification-filtering-setting (IOS-241)
151880f
@zeitschlag
Show subtitle (IOS-241)
0b74981
@zeitschlag
Dependencyinject ViewModel based on downloaded policy-data (IOS-241)
94ad86c
@zeitschlag
UI/UX-improvements (IOS-241)
363a521
@zeitschlag
Upload updated policy (IOS-241)
847cadb
@zeitschlag
Download notification-requests (IOS-241)
7cdde77
@zeitschlag
Add viewController for notification-requests (IOS-241)
5473e7f
@zeitschlag
Use correct properties for account (IOS-241)
b119a6d
@zeitschlag
Use better icon after feedback (IOS-241)
05a08f6
@zeitschlag
More feedback from Sam (IOS-241)
99f2fc9
@zeitschlag
Style cells according to Sams feedback (IOS-241)
ed4a003
@zeitschlag
Refactor code to coordinator (IOS-241)
c79e26b
@zeitschlag
Implement special sheet header (IOS-241)
6702f06
@zeitschlag
"Fix" content inset (IOS-241)
65075c5
@zeitschlag
Use SymbolConfigurations for buttons (IOS-241)
7c6c9b5 
I feel so stupid from time to time
@zeitschlag
Show account for request (IOS-241)
4cf75d3
@zeitschlag
[WIP] Prepare enum-cases to show notifications from one account (IOS-241
0d5dd51 
)
@zeitschlag
Fix build issues that happened after rebase (IOS-241)
b424dab
@zeitschlag
Show notifications from one account (IOS-241)
fb3dfb5
@zeitschlag
Some more UI-feedback (IOS-241)
8115aea
@zeitschlag
Set title and fix background color (IOS-241)
1a123d0
@zeitschlag
Show accept/reject-button (IOS-241)
e645bc1 
For now they are just ... there to gather feedback, functions follows
@zeitschlag
[WIP]: Add spinner and do something when pressing the button (IOS-241)
94a8791
@zeitschlag
[WIP] Add API-calls for accepting/rejecting notification requests (IO…
8b65421 
…S-241)
@zeitschlag
Use correct URL 🤦 (IOS-241)
55d6b28
@zeitschlag
Accept/reject notification requests (IOS-241)
5925d84
@zeitschlag
Minor cleanup (IOS-241)
67e1e5e
@zeitschlag
Add first draft for Notification-count-view (IOS-241)
48f5864
@zeitschlag
Update notifications after policy/request-change (IOS-241)
d87deff
@zeitschlag
Update policies (IOS-241)
25f15d2
@zeitschlag
Localization (IOS-241)
9e8de73
@zeitschlag
Localization for Banner (IOS-241)
ffc8026
@zeitschlag
[WIP] Plural Localization for banner-subtitle (IOS-241)
287587f 
Caveat: doesn't work yet 🤡
@zeitschlag
Reverse buttons (IOS-241)
f5bc847
@zeitschlag
Add swipe-action to dismiss (IOS-241)
ff48cc2
@zeitschlag
Add accept/dismiss-menu (IOS-241)
f3c035c
@zeitschlag
Sprinkle in some, you guessed it: Localization (IOS-241)
b3bfa51
@zeitschlag
Cleanup (IOS-241)
86aa92d
@zeitschlag zeitschlag force-pushed the ios-241-notification-filtering branch from 21b4313 to 86aa92d Compare July 24, 2024 10:35
@zeitschlag zeitschlag marked this pull request as ready for review July 24, 2024 14:40
@zeitschlag zeitschlag changed the title [WIP] Notification Filtering (IOS-241) Notification Filtering (IOS-241) Jul 24, 2024
@zeitschlag zeitschlag requested a review from kimar July 24, 2024 14:58
kimar
kimar approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@kimar kimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just a few questions / ideas and one issue with the pluralized format string.

Mastodon/Protocol/Provider/DataSourceFacade+Notifications.swift Show resolved Hide resolved
Mastodon/Protocol/Provider/DataSourceProvider+NotificationTableViewCellDelegate.swift Outdated Show resolved Hide resolved
Mastodon/Protocol/Provider/DataSourceProvider+StatusTableViewCellDelegate.swift Outdated Show resolved Hide resolved
Mastodon/Scene/Notification/Cell/NotificationFilteringBannerTableViewCell.swift Outdated Show resolved Hide resolved
...e/Notification/Notification Filtering/Requests/NotificationRequestsTableViewController.swift Outdated Show resolved Hide resolved
...e/Notification/Notification Filtering/Requests/NotificationRequestsTableViewController.swift Outdated Show resolved Hide resolved
Mastodon/Scene/Notification/NotificationTimeline/NotificationTimelineViewModel.swift Outdated Show resolved Hide resolved
MastodonSDK/Sources/MastodonSDK/Query/Query.swift Outdated Show resolved Hide resolved
MastodonSDK/Sources/MastodonLocalization/Generated/Strings.swift Show resolved Hide resolved
@zeitschlag zeitschlag merged commit 5d8e453 into develop Jul 26, 2024
2 checks passed
@zeitschlag zeitschlag deleted the ios-241-notification-filtering branch July 26, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimar kimar kimar approved these changes

Assignees

@zeitschlag zeitschlag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeitschlag @kimar