Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge case: "regeneration indicator" has different heights for missing statuses/accounts #6786

Closed
2 tasks done
trwnh opened this issue Mar 15, 2018 · 6 comments · Fixed by #12094
Closed
2 tasks done

Edge case: "regeneration indicator" has different heights for missing statuses/accounts #6786

trwnh opened this issue Mar 15, 2018 · 6 comments · Fixed by #12094
Labels
bug Something isn't working ui Front-end, design

Comments

@trwnh
Copy link
Member

trwnh commented Mar 15, 2018

When attempting to load an invalid account:
image

When attempting to load an invalid status:
image

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@trwnh
Copy link
Member Author

trwnh commented Mar 15, 2018

After some more testing: it seems that the bug is an artifact of using div.scrollable and div.item-list on the /accounts error (which demonstrates this issue), but not on any other error (which load fine). Removing those two divs (.scrollable and .item-list) in Firefox's HTML editor fixes the issue.

@ClearlyClaire ClearlyClaire added bug Something isn't working ui Front-end, design labels Mar 19, 2018
@trwnh trwnh mentioned this issue Aug 22, 2018
Closed
2 tasks
@trwnh
Copy link
Member Author

trwnh commented Aug 29, 2018 •
edited
Loading

Narrowed it down to inconsistent usage of MissingIndicator as defined in https://github.com/tootsuite/mastodon/blob/995f8b389a66ab76ec92d9a240de376f1fc13a38/app/javascript/mastodon/components/missing_indicator.js

null status (e.g. https://mastodon.social/web/statuses/1006351392063297865454545 ) works fine: https://github.com/tootsuite/mastodon/blob/800325f452200902995602ff441e2f84f684e90a/app/javascript/mastodon/features/status/index.js#L380-L387

false list (e.g. https://mastodon.social/web/timelines/list/2458 ) does not: https://github.com/tootsuite/mastodon/blob/66dbb59aa16981643e3bfa3f94d441bc3166eab3/app/javascript/mastodon/features/list_timeline/index.js#L121-L137

Not sure where to fix it with missing accounts (e.g. https://mastodon.social/web/accounts/147152679 ). It looks like this is the responsible code: https://github.com/tootsuite/mastodon/blob/f2404de871f0bdfda5c9aeeeb4c6c4d10a8da8ab/app/javascript/mastodon/features/account_timeline/components/header.js#L84-L86

...but that's being called externally elsewhere, in another function that already inserts it into both a div.scrollable and a div.item-list.

From what I can trace, the header.js above gets imported into header_container.js: https://github.com/tootsuite/mastodon/blob/f2404de871f0bdfda5c9aeeeb4c6c4d10a8da8ab/app/javascript/mastodon/features/account_timeline/containers/header_container.js#L4

The null account logic is happening somewhere here: https://github.com/tootsuite/mastodon/blob/f2404de871f0bdfda5c9aeeeb4c6c4d10a8da8ab/app/javascript/mastodon/features/account_timeline/containers/header_container.js#L31-L39

@trwnh trwnh mentioned this issue Aug 29, 2018
Merged
@trwnh
Copy link
Member Author

trwnh commented Aug 29, 2018 •
edited
Loading

Visual summary:

x Status List Account
Default image image image
With CSS theme image image image

Gargron pushed a commit that referenced this issue Sep 1, 2018
@trwnh @Gargron
Fix the display of missing lists (#8523)
6a147f8 
* Fix the display of missing lists

See #6786 -- this fixes part of the issue pertaining to lists that don't exist. I copied the Column being returned from the missing status logic, which works fine. Prior to this, the missing lists logic would generate a column with no back button and with a broken layout. This doesn't fix the broken display of missing accounts -- the column construction pertaining to that logic happens in multiple external functions.

* import ColumnBackButton

missed the import with the first commit
@trwnh
Copy link
Member Author

trwnh commented Sep 12, 2018

Now that #8523 has been merged:

x Status List Account
Default image image image
With CSS theme image image image

kyori19 pushed a commit to kyori19/mastodon that referenced this issue Sep 20, 2018
@trwnh @kyori19
Fix the display of missing lists (mastodon#8523)
caf12e0 
* Fix the display of missing lists

See mastodon#6786 -- this fixes part of the issue pertaining to lists that don't exist. I copied the Column being returned from the missing status logic, which works fine. Prior to this, the missing lists logic would generate a column with no back button and with a broken layout. This doesn't fix the broken display of missing accounts -- the column construction pertaining to that logic happens in multiple external functions.

* import ColumnBackButton

missed the import with the first commit
@trwnh trwnh mentioned this issue Oct 7, 2019
Merged
@trwnh
Copy link
Member Author

trwnh commented Oct 7, 2019 •
edited
Loading

Possibly due to #12084 (but I'm not sure, as I don't know what commit mastodon.social is running right now), the mascot and error message are finally centered in all 3 cases of status/list/account, except the "invalid account" case has no Back button as a header.

Presumably this is the relevant code? Would a PR adding <ColumnBackButton> for !isAccount do the trick?

https://github.com/tootsuite/mastodon/blob/a58218562555c32bd0ec6c2ca2cc19ac4984904c/app/javascript/mastodon/features/account_timeline/index.js#L80-L104

@Gargron
Copy link
Member

Gargron commented Oct 7, 2019

@trwnh Yes, I think so

@trwnh trwnh mentioned this issue Oct 7, 2019
Merged
Gargron pushed a commit that referenced this issue Oct 7, 2019
@trwnh @Gargron
Add missing back button header for invalid account (#12094)
95f21ab 
Should fix #6786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ui Front-end, design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add column back button for missing account in web UI
3 participants
@Gargron @ClearlyClaire @trwnh