Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential private status leak #10969

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

ClearlyClaire
Copy link
Contributor

Fix potential leak of private statuses when the HTML view of a status is requested by a remote account with valid HTTP signature.

This is fairly minor as that leak would only happen if all the following conditions are met:

  1. a request is made with a valid HTTP signature for a remote account
  2. this requests yields the HTML representation and not the ActivityStreams or atom one
  3. the requested status is public/unlisted
  4. the requested status is either in reply to a private status viewable by the requesting account or has private replies viewable by the requesting account
  5. a second query, from someone not allowed to view these toots, is made while the cache is valid (10-seconds timeframe)

I do not believe that 1 & 2 can currently occur simultaneously in the wild, and the other conditions are very unlikely, but it doesn't hurt to fix it.

@Gargron Gargron merged commit 7fa23ec into mastodon:master Jun 5, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
rtucker pushed a commit to vulpineclub/mastodon that referenced this pull request Jan 7, 2021
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants