Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual scrolling issue on Firefox/Windows #12648

Merged
merged 1 commit into from
Dec 19, 2019

Commits on Dec 17, 2019

  1. Fix manual scrolling issue on Firefox/Windows

    Fixes mastodon#12607
    
    `will-change: transform` apparently makes manual scrolling impossible on
    Firefox/Windows. While this should probably be considered a Firefox bug,
    `will-change: transform` seem like a very aggressive performance hint that
    may possibly make the browser consume more resources than needed, especially
    in multiple-column mode.
    
    This was originally added to improve scrolling performances on mobile, but
    I think this isn't necessary anymore, because of the two following reasons:
    - `contain: paint` (which is implied by `contain: strict`, which we apply
      whenever the browser supports grids) should have similar effects
    - in single-column mode, the scrolling container is the root element, which
      I believe is optimized in at least Chromium
    
    Keep in mind that I have not been able to make in-depth benchmarks, and
    especially not been able to try on mobile, so performances should probably
    be investigated further…
    ClearlyClaire committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    b9c4e44 View commit details
    Browse the repository at this point in the history