Make dropdown animations respect their placement #8292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the corner radius on the privacy dropdown button when using top placement
Gargron
approved these changes
Aug 19, 2018
|
After this merge I get: On my console when the page is opened. Should placement really be required? it doesn't seem like the case for the other component. |
kyori19
pushed a commit
to kyori19/mastodon
that referenced
this pull request
Sep 20, 2018
* Make dropdown animations respect their placement Also fix the corner radius on the privacy dropdown button when using top placement * Fix code style issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Kind of a follow-up to #6091)
Makes dropdowns (including the privacy dropdown) using top placement have the correct transform origin.
Also makes the privacy dropdown button not look strange when using top placement.
