Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grab bag #207

Merged
merged 19 commits into from
Oct 27, 2018
Merged

Grab bag #207

merged 19 commits into from
Oct 27, 2018

Commits on Oct 21, 2018

  1. Fix spacing in README 

    Fixes #193 (thanks @MarkWithall)
    @matatk
    matatk committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    8bd59ec View commit details
    Browse the repository at this point in the history

  2. Don't need to check DOMContentLoaded 

    ...as the scripts are included via <script> tags at the end of the <body>.

Closes #192.
    @matatk
    matatk committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    bb4ba32 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. Remove FIXME note (not a problem)

    @matatk
    matatk committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    3c916c8 View commit details
    Browse the repository at this point in the history

  2. Clean up content script injector definition 

    This uses ternery operator notation to allow the injector to appear as
one const variable in the generated code.
    @matatk
    matatk committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    1ace0f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Clean up specialPages definition

    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    87645d6 View commit details
    Browse the repository at this point in the history

  2. Clean up defaults definitions 

    Unfortunately this still leaves some "Object.freeze()" calls in code
that doesn't use it, but I can't see a clean way to get rid of these.
    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    afc538d View commit details
    Browse the repository at this point in the history

  3. Understood what is going on here: updated comment

    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    0710373 View commit details
    Browse the repository at this point in the history

  4. Code clean-up in support of #195

    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    ed1cc76 View commit details
    Browse the repository at this point in the history

  5. Cleaner conditional code in background script 

    * Declare functions at outer scope.  It is then unnecessary to define
  them using ternary notation, as the minifier will remove them.
* Ensure DevTools stuff does not get build for Edge.
* More conditional checking where stuff is used.
* Terser now removes various things like sidebar-related variables on
  Chrome automatically.

Fixes #195.
    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    ade347a View commit details
    Browse the repository at this point in the history

  6. DRY testing for non-special pages 

    Instead of checking for special pages, check that a page is
content-scriptable, as this is more in line with what the extension
wants to do.

Fixes #206.
    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    9a51694 View commit details
    Browse the repository at this point in the history

  7. Conditional code in options script 

    Only add the interface option on sidebar-supporting browsers (the
related functions are automatically pruned).

Also fixes #195 :-).
    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    4e3cf79 View commit details
    Browse the repository at this point in the history

  8. Remove "show all landmarks" command for 2.4.0 

    This will be back...

Ref #120.
    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    38cd3de View commit details
    Browse the repository at this point in the history

  9. Re-order 2.4.0 changes in README; phrasing tweaks

    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    dfaeb30 View commit details
    Browse the repository at this point in the history

  10. Rename message files 

    * In line with other "assembled" files.
* This might make merging the "show all" changes back in from that commit more interesting :-).
    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    59e7ca8 View commit details
    Browse the repository at this point in the history

  11. Only ask for landmarks once at a time 

    When multiple GUIs are open, be sure to only request landmarks from the
active tab once. Fixes #205.
    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    ce28bc5 View commit details
    Browse the repository at this point in the history

  12. Rename isHidden() to isVisuallyHidden() for clarity 

    As per the recently-retconned PR notes for #85.

Partly addresses #197.
    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    cb2b567 View commit details
    Browse the repository at this point in the history

  13. Clarify visually-hidden in README 

    Ref #197
    @matatk
    matatk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    827b46a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2018

  1. Update documentation around unlabelled form and region 

    * Clarify support in the README (and why).
* Tweak the rationale in the README.
* Clarify behaviour in comments.

Fixes #197.
    @matatk
    matatk committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    50cbd68 View commit details
    Browse the repository at this point in the history

  2. Remove Opera note from README 

    2.3.1 was reviewed recently.
    @matatk
    matatk committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    8caf774 View commit details
    Browse the repository at this point in the history