Skip to content
This repository was archived by the owner on Jul 29, 2025. It is now read-only.

Commit f612388

Browse files
patrick91Matt Goo
authored andcommitted
fix(button): Rename stroked to outlined (#74)
1 parent 3bbbbe8 commit f612388

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

packages/button/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Prop Name | Type | Description
3232
className | String | Classes to be applied to the root element.
3333
raised | Boolean | Enables raised variant.
3434
unelevated | Boolean | Enables unelevated variant.
35-
stroked | Boolean | Enables stroked variant.
35+
outlined | Boolean | Enables outlined variant.
3636
icon | Element | Icon to render within root element.
3737
children | String | Text to be displayed within root element.
3838
disabled | Boolean | Disables button if true.

packages/button/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export class Button extends Component {
99
className,
1010
raised,
1111
unelevated,
12-
stroked,
12+
outlined,
1313
icon,
1414
children,
1515
initRipple,
@@ -20,7 +20,7 @@ export class Button extends Component {
2020
const classes = classnames('mdc-button', className, {
2121
'mdc-button--raised': raised,
2222
'mdc-button--unelevated': unelevated,
23-
'mdc-button--stroked': stroked,
23+
'mdc-button--outlined': outlined,
2424
});
2525

2626
return (
@@ -51,7 +51,7 @@ export class Button extends Component {
5151
Button.propTypes = {
5252
raised: PropTypes.bool,
5353
unelevated: PropTypes.bool,
54-
stroked: PropTypes.bool,
54+
outlined: PropTypes.bool,
5555
disabled: PropTypes.bool,
5656
unbounded: PropTypes.bool,
5757
initRipple: PropTypes.func,
@@ -63,7 +63,7 @@ Button.propTypes = {
6363
Button.defaultProps = {
6464
raised: false,
6565
unelevated: false,
66-
stroked: false,
66+
outlined: false,
6767
disabled: false,
6868
unbounded: false,
6969
initRipple: () => {},

test/screenshot/button/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ ReactDOM.render((
2929
<Button raised>Raised</Button>
3030
</div>
3131
<div className='button-container'>
32-
<Button stroked>Stroked</Button>
32+
<Button outlined>Outlined</Button>
3333
</div>
3434
<div className='button-container'>
3535
<Button unelevated>Unelevated</Button>

test/screenshot/golden.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
"material-icon/menu.html": "790b2076760612c6c91ee0f6bb42aa3603b30c2a60f302de22429c2572645640",
99
"fab/standard.html": "c0a68de7fa657ac62622e4f541c8e1eaef7544d12afb26b3421c3b04d58effa6",
1010
"card/index.html": "fe449cbe9e766c68386704b6cbfc3f3f508fbc947c6cdec97fa1b05183d0e61d",
11-
"button/index.html": "5a31c21c642f7536a08276c9367aae19004e0eea550898d92ecd962bfc5bdad4",
11+
"button/index.html": "66a897d49f43d12844333b54370e7a5c441a9f5c563a8703f5e61251fdd6bde7",
1212
"material-icon/index.html": "20c6c6bfe5ff444b52952343661151226a8786001fdd3e66e51e80903c3a9292",
1313
"line-ripple/index.html": "4b8eca29eb61834715ca0eeaec2c620358fa943623b5235ca02717c351f1485b",
1414
"floating-label/index.html": "67d9b6caad3a494563e2584ac6af071bbb3b73afc3e945f8299ca720b4015256",
1515
"notched-outline/index.html": "73394b6d7dcd94bc930dc740db8199000b94d365d7d703381ef01b3318b97d8c",
1616
"text-field/icon/index.html": "ce761ca24e2d5ca425ad1783c9e2d476b84f65232d86c4fdc0e8c3e756311c8f",
1717
"text-field/helper-text/index.html": "722a8eb27cbde5e32fc92c70e6c107f8ef75bff1abb3914fd2ef58fd49b678bb",
1818
"text-field/index.html": "8cac264e77fe54efcc659edeb8ef1e530963f9efbe8a26edd2e54780beafcb71"
19-
}
19+
}

test/unit/button/index.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ test('renders a unelevated button', () => {
3333
assert.isTrue(wrapper.hasClass('mdc-button--unelevated'));
3434
});
3535

36-
test('renders a stroked button', () => {
37-
const wrapper = shallow(<Button stroked />);
38-
assert.isTrue(wrapper.hasClass('mdc-button--stroked'));
36+
test('renders an outlined button', () => {
37+
const wrapper = shallow(<Button outlined />);
38+
assert.isTrue(wrapper.hasClass('mdc-button--outlined'));
3939
});
4040

4141
test('default initRipple function', () => {

0 commit comments

Comments
 (0)