This repository was archived by the owner on Jul 29, 2025. It is now read-only.
feat(tab): Add ripple #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moog16
reviewed
Sep 17, 2018
test/unit/tab/index.test.js
Outdated
| @@ -212,12 +212,6 @@ test('should render content with icon and text children', () => { | |||
| assert.equal(textLabel.type(), 'span'); | |||
| }); | |||
|
|
|||
| test('should render mdc tab ripple', () => { | |||
There was a problem hiding this comment.
I think you can change this to find the element, instead of doing .hasClass
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 97.61% 97.36% -0.26%
==========================================
Files 27 28 +1
Lines 1089 1099 +10
Branches 107 107
==========================================
+ Hits 1063 1070 +7
- Misses 26 29 +3
Continue to review full report at Codecov.
|
moog16
approved these changes
Sep 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
TabRipplecomponent used inTab