-
Notifications
You must be signed in to change notification settings - Fork 230
Add support for outlined buttons #74
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
@kfranqueiro I didn't notice! Thanks, I've updated :) |
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 18 18
Lines 617 617
Branches 49 49
=======================================
Hits 610 610
Misses 7 7
Continue to review full report at Codecov.
|
Changes look good to me. I'm going to run it on my side and get the screenshot tests working since #71 is still an issue. Because of #71 you cannot run the tests against TravisCI. So what I'll do is:
|
Related screenshot tests PR: #78. @patrick91 could you please sign it? |
@patrick91 #78 tests are passing! Will merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good per #78
No description provided.