Skip to content

Commit

Permalink
fix(scripts): Ensure determine-pkg-versions outputs correct info (#261)
Browse files Browse the repository at this point in the history
- Ensure new version output by determine-pkg-versions is correct
- Ensure proper publishConfig flags are sent to UpdatedPackagesCollector
  • Loading branch information
traviskaufman committed Feb 7, 2017
1 parent f3cc9ab commit 1097e6f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion scripts/determine-pkg-versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function determineVersion(pkg, commitInfos) {
}

return commitInfos.reduce(pickBestVersionInfo(pkg), {
version: currentVersion,
version: semver.inc(currentVersion, 'patch'),
changeType: 'patch',
causedByCommit: '(dependency update - part of packages to be updated but no explicit commits referencing it)',
});
Expand Down
4 changes: 2 additions & 2 deletions scripts/lib/get-updated-pkgs.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ const Repository = require('lerna/lib/Repository');
const UpdatedPackagesCollector = require('lerna/lib/UpdatedPackagesCollector');
const lernaLogger = require('lerna/lib/logger');
const progressBar = require('lerna/lib/progressBar');
const lernaJson = require('../../lerna.json');

module.exports = function() {
const repository = new Repository();
const origInfoFn = lernaLogger.info;
const origBarDescriptor = Object.getOwnPropertyDescriptor(progressBar, 'bar');
const lernaCommand = {
repository,
getOptions: () => ({}),
publishConfig: {},
getOptions: () => lernaJson.publishConfig,
};
const collector = new UpdatedPackagesCollector(lernaCommand);

Expand Down

0 comments on commit 1097e6f

Please sign in to comment.